* Add DigestBuilder.

* Make digest and claims private.

* refactor: Refactor DigestBuilder

- Refactored `src/digest.rs` to replace `Vec<u8>` storage with dedicated Write I/O.
- Removed optional `hasher` and introduced dedicated factory method.
- Reworked digest computation and mapping into separate functions.
- Merged build and digest computation to enhance coherence.
- Improved type safety with Result error propagation.

* Propagate DigestBuilder changes.

* Fix tests.

* Correct assertion for OutputSize scale.

* Remove commented.

* Remove dbg!.

* Fixup rebase.

---------

Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: François Garillot <francois@garillot.net>

feat: add a digest to R1CSShape (microsoft#49)

* refactor: Refactor Digestible trait

- Removed `to_bytes` method from the `Digestible` trait in `src/digest.rs` file.

* fix: Make bincode serialization in digest.rs more rigorous

- Updated `bincode::serialize_into(byte_sink, self)` with a configurable version to enable "little endian" and "fixint encoding" options.
- Added a comment in `src/digest.rs` about `bincode`'s recursive length-prefixing during serialization.

* refactor: Refactor digest computation using `OnceCell` and `DigestComputer`

This gives up on a generic builder and instead uses an idempotent `OnceCell`
+ a generic digest computer to populate the digest of a structure.

- this shows how to set up digest computation so it doesn't depend on the digest field,
- the digest can't be set twice,
- an erroneous digest can't be inferred from the serialized data.

In Details:

- Overhauled digest functionality in multiple files by replacing `DigestBuilder` with `DigestComputer`, significantly altering the handling of hashes.
- Incorporated `once_cell::sync::OnceCell` and `ff::PrimeField` dependencies to improve performance and simplify code.
- Modified `VerifierKey` and `RunningClaims` structures to include a `OnceCell` for digest, leading to a change in function calls and procedures.
- Simplified `setup_running_claims` by removing error handling and directly returning `RunningClaims` type.
- Adapted test functions according to the changes including the removal of unnecessary unwrapping in certain scenarios.
- Updated Cargo.toml with the new dependency `once_cell` version `1.18.0`.

* refactor: rename pp digest in VerifierKey to pp_digest

* feat: add a digest to R1CSShape

* fix: Small issues

- Introduced a new assertion within the `write_bytes` method of `src/supernova/mod.rs` for validating whether the `claims` are empty
- Improved code comment clarity regarding the creation of a running claim in `src/supernova/mod.rs`.

* Add DigestBuilder.

* Make digest and claims private.

* refactor: Refactor DigestBuilder

- Refactored `src/digest.rs` to replace `Vec<u8>` storage with dedicated Write I/O.
- Removed optional `hasher` and introduced dedicated factory method.
- Reworked digest computation and mapping into separate functions.
- Merged build and digest computation to enhance coherence.
- Improved type safety with Result error propagation.

* Propagate DigestBuilder changes.

* Fix tests.

* Correct assertion for OutputSize scale.

* Remove commented.

* Remove dbg!.

* Fixup rebase.

---------

Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: François Garillot <francois@garillot.net>

feat: add a digest to R1CSShape (microsoft#49)

* refactor: Refactor Digestible trait

- Removed `to_bytes` method from the `Digestible` trait in `src/digest.rs` file.

* fix: Make bincode serialization in digest.rs more rigorous

- Updated `bincode::serialize_into(byte_sink, self)` with a configurable version to enable "little endian" and "fixint encoding" options.
- Added a comment in `src/digest.rs` about `bincode`'s recursive length-prefixing during serialization.

* refactor: Refactor digest computation using `OnceCell` and `DigestComputer`

This gives up on a generic builder and instead uses an idempotent `OnceCell`
+ a generic digest computer to populate the digest of a structure.

- this shows how to set up digest computation so it doesn't depend on the digest field,
- the digest can't be set twice,
- an erroneous digest can't be inferred from the serialized data.

In Details:

- Overhauled digest functionality in multiple files by replacing `DigestBuilder` with `DigestComputer`, significantly altering the handling of hashes.
- Incorporated `once_cell::sync::OnceCell` and `ff::PrimeField` dependencies to improve performance and simplify code.
- Modified `VerifierKey` and `RunningClaims` structures to include a `OnceCell` for digest, leading to a change in function calls and procedures.
- Simplified `setup_running_claims` by removing error handling and directly returning `RunningClaims` type.
- Adapted test functions according to the changes including the removal of unnecessary unwrapping in certain scenarios.
- Updated Cargo.toml with the new dependency `once_cell` version `1.18.0`.

* refactor: rename pp digest in VerifierKey to pp_digest

* feat: add a digest to R1CSShape

* fix: Small issues

- Introduced a new assertion within the `write_bytes` method of `src/supernova/mod.rs` for validating whether the `claims` are empty
- Improved code comment clarity regarding the creation of a running claim in `src/supernova/mod.rs`.

* Add DigestBuilder.

* Make digest and claims private.

* refactor: Refactor DigestBuilder

- Refactored `src/digest.rs` to replace `Vec<u8>` storage with dedicated Write I/O.
- Removed optional `hasher` and introduced dedicated factory method.
- Reworked digest computation and mapping into separate functions.
- Merged build and digest computation to enhance coherence.
- Improved type safety with Result error propagation.

* Propagate DigestBuilder changes.

* Fix tests.

* Correct assertion for OutputSize scale.

* Remove commented.

* Remove dbg!.

* Fixup rebase.

---------

Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>
Co-authored-by: François Garillot <francois@garillot.net>

feat: add a digest to R1CSShape (#49)

* refactor: Refactor Digestible trait

- Removed `to_bytes` method from the `Digestible` trait in `src/digest.rs` file.

* fix: Make bincode serialization in digest.rs more rigorous

- Updated `bincode::serialize_into(byte_sink, self)` with a configurable version to enable "little endian" and "fixint encoding" options.
- Added a comment in `src/digest.rs` about `bincode`'s recursive length-prefixing during serialization.

* refactor: Refactor digest computation using `OnceCell` and `DigestComputer`

This gives up on a generic builder and instead uses an idempotent `OnceCell`
+ a generic digest computer to populate the digest of a structure.

- this shows how to set up digest computation so it doesn't depend on the digest field,
- the digest can't be set twice,
- an erroneous digest can't be inferred from the serialized data.

In Details:

- Overhauled digest functionality in multiple files by replacing `DigestBuilder` with `DigestComputer`, significantly altering the handling of hashes.
- Incorporated `once_cell::sync::OnceCell` and `ff::PrimeField` dependencies to improve performance and simplify code.
- Modified `VerifierKey` and `RunningClaims` structures to include a `OnceCell` for digest, leading to a change in function calls and procedures.
- Simplified `setup_running_claims` by removing error handling and directly returning `RunningClaims` type.
- Adapted test functions according to the changes including the removal of unnecessary unwrapping in certain scenarios.
- Updated Cargo.toml with the new dependency `once_cell` version `1.18.0`.

* refactor: rename pp digest in VerifierKey to pp_digest

* feat: add a digest to R1CSShape

* fix: Small issues

- Introduced a new assertion within the `write_bytes` method of `src/supernova/mod.rs` for validating whether the `claims` are empty
- Improved code comment clarity regarding the creation of a running claim in `src/supernova/mod.rs`.

Co-authored-by: porcuquine <1746729+porcuquine@users.noreply.github.com>

* refactor: Refactor Digestible trait

- Removed `to_bytes` method from the `Digestible` trait in `src/digest.rs` file.

* fix: Make bincode serialization in digest.rs more rigorous

- Updated `bincode::serialize_into(byte_sink, self)` with a configurable version to enable "little endian" and "fixint encoding" options.
- Added a comment in `src/digest.rs` about `bincode`'s recursive length-prefixing during serialization.

* refactor: Refactor digest computation using `OnceCell` and `DigestComputer`

This gives up on a generic builder and instead uses an idempotent `OnceCell`
+ a generic digest computer to populate the digest of a structure.

- this shows how to set up digest computation so it doesn't depend on the digest field,
- the digest can't be set twice,
- an erroneous digest can't be inferred from the serialized data.

In Details:

- Overhauled digest functionality in multiple files by replacing `DigestBuilder` with `DigestComputer`, significantly altering the handling of hashes.
- Incorporated `once_cell::sync::OnceCell` and `ff::PrimeField` dependencies to improve performance and simplify code.
- Modified `VerifierKey` and `RunningClaims` structures to include a `OnceCell` for digest, leading to a change in function calls and procedures.
- Simplified `setup_running_claims` by removing error handling and directly returning `RunningClaims` type.
- Adapted test functions according to the changes including the removal of unnecessary unwrapping in certain scenarios.
- Updated Cargo.toml with the new dependency `once_cell` version `1.18.0`.

* refactor: rename pp digest in VerifierKey to pp_digest

* feat: add a digest to R1CSShape

* fix: Small issues

- Introduced a new assertion within the `write_bytes` method of `src/supernova/mod.rs` for validating whether the `claims` are empty
- Improved code comment clarity regarding the creation of a running claim in `src/supernova/mod.rs`.