Improve error handling #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result, propagate errors instead of panicking withexpectNovaError::SynthesisError, retain information about the original bellpepper error. SinceNovaErrorimplementsClonebut bellpepper'sSynthesisErrordoes not, we keep the error information as aString.This commit only fixes low-hanging fruit in lib.rs, for functions that already return a
Resultand can easily propagate errors just by replacingexpect(...)with?. There are still manyunwrap()calls in functions returningResultin other modules, particularly gadgets. But I don't understand the code well in those parts, and I suspect some of thoseunwrap()s actually can't fail based on invariants of the code, so it makes perfect sense to leave them as is.