Small improvement to the minroot example #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about 10% improvement for the non-release mode
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Nov 27, 2023
* Small code improvement to the minroot example (microsoft#264) about 10% improvement for the non-release mode * Reduce duplicate code across different curve cycle providers (microsoft#255) * refactor: impl folding macro * refactor: generalize curve test * chore: rename impl_folding to impl_engine * reorganize provider module (microsoft#267) --------- Co-authored-by: field-worker <151173028+field-worker@users.noreply.github.com> Co-authored-by: ashWhiteHat <phantomofrotten@gmail.com> Co-authored-by: Srinath Setty <srinath@microsoft.com>
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 10% improvement for the non-release mode. My guess is that examples are typically no run with the
releaseflag.