refactor r1cs::is_valid and provider::cpu_best_multiexp #240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
I found some methods that can be improved.
is_validclosurecpu_best_multiexpis_valid
This closure checks whether r1cs matrix row is in range and returns error if invalid.
I modified it and made it returning Err without using
is_err().cpu_best_multiexp
According to rayon doc, parallel iterators are more efficient than scope.
I replaced scope with parallel iterations.
I also avoided unnecessary initialization.
I would appreciate it if you could confirm.
Thank you.