refactor: remove clippy attributes #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
srinathsetty
approved these changes
Oct 16, 2023
Collaborator
|
Looks good! thanks! |
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Oct 17, 2023
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Oct 27, 2023
* refactor: Refactor sparse namespace and SparseMatrix visibility - Modifies the visibility of `sparse` module from public to private - Makes `SparseMatrix` class within `sparse` module public - Updates `SparseMatrix` import across several files to accommodate visibility changes * fix: define matrix inputs in idiomatic Nova style * chore: Refactor dependencies for r1cs module - Shifted `proptest` and `rand` dependencies to dev-dependencies in `Cargo.toml` - Introduced testing flag for `util` module under `r1cs` * refactor: remove clippy attributes (microsoft#233) --------- Co-authored-by: bing <bingcicle@proton.me>
hero78119
pushed a commit
to hero78119/SuperNova
that referenced
this pull request
Jan 5, 2024
* chore: Parallelise 'Pi' computing * chore: Put 'x' out of brackets
huitseeker
pushed a commit
to lurk-lang/Nova
that referenced
this pull request
Jan 25, 2024
* chore: Parallelise 'Pi' computing * chore: Put 'x' out of brackets
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Jan 26, 2024
* chore: Parallelise 'Pi' computing * chore: Put 'x' out of brackets
huitseeker
pushed a commit
to lurk-lang/Nova
that referenced
this pull request
Jan 26, 2024
* chore: Parallelise 'Pi' computing * chore: Put 'x' out of brackets
huitseeker
pushed a commit
to lurk-lang/Nova
that referenced
this pull request
Jan 26, 2024
* chore: Parallelise 'Pi' computing * chore: Put 'x' out of brackets
huitseeker
pushed a commit
to lurk-lang/Nova
that referenced
this pull request
Feb 21, 2024
* chore: Parallelise 'Pi' computing * chore: Put 'x' out of brackets
huitseeker
pushed a commit
to lurk-lang/Nova
that referenced
this pull request
May 2, 2024
* chore: Parallelise 'Pi' computing * chore: Put 'x' out of brackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR getting rid of some clippy attributes.
clippy::upper_case_acronymsseems to not trigger forShapeCSandTestShapeCS, so this just removes the unnecessary allows for those.Removing
clippy::needless_range_loopis a bit more opinionated. Used afor_each()to get rid of it but conceptually I can see it being easier for some to read a for i in X notation instead, even though the result is the same. I can undo this change, if the for i in X style is preferable here.The only clippy attribute that can't be gotten rid of is the
upper_case_acronymsannotation forNIFS.