Skip to content

Conversation

@keveleigh
Copy link
Contributor

@keveleigh keveleigh commented Oct 21, 2022

Overview

Although parsing the folder names is still not the most robust, this is the most straight forward fix for now unless (until?) we rethink this log entirely.

Changes

@github-actions github-actions bot added the MRTK2 label Oct 21, 2022
@keveleigh keveleigh force-pushed the test-fixing-build-logic-for-finding-sdk branch 3 times, most recently from dc39b70 to 8e0990c Compare October 22, 2022 02:10
@keveleigh keveleigh force-pushed the test-fixing-build-logic-for-finding-sdk branch from 616f4ce to ddc8830 Compare October 24, 2022 17:25
@keveleigh keveleigh marked this pull request as ready for review October 24, 2022 17:39
@keveleigh keveleigh changed the title Test fixing build logic for finding sdk Update build logic for finding sdk Oct 24, 2022
@keveleigh keveleigh self-assigned this Oct 24, 2022
@keveleigh keveleigh enabled auto-merge (squash) October 24, 2022 20:46
@david-c-kline david-c-kline self-assigned this Nov 2, 2022
@keveleigh keveleigh merged commit 287a91b into microsoft:main Nov 4, 2022
@ccpp
Copy link

ccpp commented Nov 4, 2022

Thank you, this fix looks good and should resolve our issue in future builds

@keveleigh keveleigh deleted the test-fixing-build-logic-for-finding-sdk branch November 8, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure, invalid SDK version reported in Appxmanifest

3 participants