-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
BugHelp WantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunities
Description
Describe the bug
In a command-line build on GitHub we experience build failure due to an invalid AppxManifest.xml.
MRTK constructs an invalid Package.appxmanifest with SDK versions like "wdf" (GitHub windows-latest, or "winv6.3" (windows-2019):
<Dependencies>
<TargetDeviceFamily Name="Windows.Holographic" MinVersion="10.0.10240.0" MaxVersionTested="wdf" />
<PackageDependency Name="Microsoft.VCLibs.140.00" MinVersion="14.0.30704.0" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" />
</Dependencies>The version name is wrongly constructed from Windows Kits folder name in UpdateDependenciesElement.
To reproduce
Steps to reproduce the behavior:
Use the following PowerShell lines:
Install-Module UnitySetup -Force
Import-Module UnitySetup
Install-UnitySetupInstance -Installers ( `
Find-UnitySetupInstaller -Version "2019.4.32f1" -Components 'Windows','Windows_IL2CPP','UWP_IL2CPP')
Start-UnityEditor -Project .\ `
-ExecuteMethod Microsoft.MixedReality.Toolkit.Build.Editor.UnityPlayerBuildTools.StartCommandLineBuild `
-BuildTarget WSAPlayer `
-BatchMode `
-LogFile .\Logs\Build.log `
-Wait `
-AdditionalArguments "-verbose -nographics -logDirectory Logs -buildAppx -arm64 -release" `
-VerboseExpected behavior
The .appx is built with a valid AppxManifest.xml.
Your setup (please complete the following information)
- Unity Version 2019.4.32f1
- MRTK Version 0.7.2, 0.8.2
- OS: GitHub-hosted windows runners
Target platform (please complete the following information)
- HoloLens 2
Metadata
Metadata
Assignees
Labels
BugHelp WantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunities