Oculus visualization now integrated with MRTK #10067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
reviewed
Jul 13, 2021
Assets/MRTK/Providers/Oculus/XRSDK/Controllers/OculusXRSDKTouchController.cs
Outdated
Show resolved
Hide resolved
Assets/MRTK/Providers/Oculus/XRSDK/Controllers/OculusXRSDKTouchController.cs
Show resolved
Hide resolved
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
NOTE: This also fixes an error that was introduced when the UnityEngine import was added to the OculusXRSDKDeviceManager class Assets\MRTK\Providers\Oculus\XRSDK\OculusXRSDKDeviceManager.cs(17,7): error CS0105: The using directive for 'UnityEngine' appeared previously in this namespace |
keveleigh
approved these changes
Jul 13, 2021
Contributor
keveleigh
left a comment
There was a problem hiding this comment.
Big fan of the direction this PR is taking, moving some of this visualization work more in-box!
Assets/MRTK/Providers/Oculus/XRSDK/Controllers/OculusXRSDKTouchController.cs
Outdated
Show resolved
Hide resolved
Assets/MRTK/Providers/Oculus/XRSDK/Profiles/DefaultOculusXRSDKDeviceManagerProfile.asset
Show resolved
Hide resolved
…hController.cs Co-authored-by: Kurtis <kurtie@microsoft.com>
8739c5d to
10666b1
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
RogPodge
added a commit
that referenced
this pull request
Dec 14, 2021
* Oculus visualization now merged seemlessly with MRTK * addressing code review comments * Update Assets/MRTK/Providers/Oculus/XRSDK/Controllers/OculusXRSDKTouchController.cs Co-authored-by: Kurtis <kurtie@microsoft.com> Co-authored-by: Kurtis <kurtie@microsoft.com>
m-the-hoff
pushed a commit
that referenced
this pull request
Dec 15, 2021
Oculus visualization now integrated with MRTK (#10067)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously Oculus controllers managed their visuals completely separately from MRTK. This PR refactors the Oculus Touch Controllers to use the visualizer in a similar manner as the WMR controllers. For consistency, it also makes it so avatar hands can be rendered at the same time as the controller models, since Oculus's OvrAvatar functionality operates in it's own system and cannot be managed easily by MRTK.
Changes