Execution Tests: Long Vectors fix-up HLK feature reference.#8353
Merged
Conversation
Contributor
You can test this locally with the following command:git-clang-format --diff ec6ba97b757633c2e680d307342716527645930c 7600fbee39ef24cdd80717eb07898398b77812b4 -- tools/clang/unittests/HLSLExec/LongVectors.cppView the diff from clang-format here.diff --git a/tools/clang/unittests/HLSLExec/LongVectors.cpp b/tools/clang/unittests/HLSLExec/LongVectors.cpp
index 22872c40..51e4f412 100644
--- a/tools/clang/unittests/HLSLExec/LongVectors.cpp
+++ b/tools/clang/unittests/HLSLExec/LongVectors.cpp
@@ -2996,9 +2996,9 @@ public:
#define HLK_TEST_DOUBLE(Op, DataType) \
TEST_METHOD(Op##_##DataType) { \
BEGIN_TEST_METHOD_PROPERTIES() \
- TEST_METHOD_PROPERTY( \
- "Kits.Specification", \
- "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision.Optional") \
+ TEST_METHOD_PROPERTY("Kits.Specification", \
+ "Device.Graphics.D3D12.DXILCore.ShaderModel69." \
+ "DoublePrecision.Optional") \
END_TEST_METHOD_PROPERTIES() \
runTest<DataType, OpType::Op>(); \
}
@@ -3006,9 +3006,9 @@ public:
#define HLK_WAVEOP_TEST_DOUBLE(Op, DataType) \
TEST_METHOD(Op##_##DataType) { \
BEGIN_TEST_METHOD_PROPERTIES() \
- TEST_METHOD_PROPERTY( \
- "Kits.Specification", \
- "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision.Optional") \
+ TEST_METHOD_PROPERTY("Kits.Specification", \
+ "Device.Graphics.D3D12.DXILCore.ShaderModel69." \
+ "DoublePrecision.Optional") \
END_TEST_METHOD_PROPERTIES() \
runWaveOpTest<DataType, OpType::Op>(); \
}
|
bob80905
approved these changes
Apr 8, 2026
damyanp
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TAEF metadata for referencing the HLK feature name was not conformant.
Manually verified by importing the updated test binary and requirement files to a custom HLK server setup to verify end-to-end.
Resolves the DXC side work for #7611