Workaround broken GitHub runner images #6683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want this change to stick around forever but we need it to work around the broken GitHub runner images: actions/runner-images#10004 Related microsoft#6668
I'm guessing something changed about how this is interpreted in the updated visual studio and it now needs to be before the declaration. ../projects/dxilconv/include/ShaderBinary/ShaderBinary.h
Member
I think that's true for the mutex/constexpr thing, but not for the moved pragma, right? |
damyanp
approved these changes
Jun 11, 2024
Collaborator
Author
Probably right. I just added that change now because the debug build failed on my first change. I'll update the description. |
hekota
approved these changes
Jun 11, 2024
llvm-beanz
added a commit
to llvm-beanz/DirectXShaderCompiler
that referenced
this pull request
Jun 12, 2024
This removes the hack introduced in microsoft#6683 to workaround issues in the GitHub and ADO runner image: actions/runner-images#10004 Rumor has it the runner images are now fixed... let's see. Fixes microsoft#6674
llvm-beanz
added a commit
that referenced
this pull request
Jun 17, 2024
This removes the hack introduced in #6683 to workaround issues in the GitHub and ADO runner image: actions/runner-images#10004 Rumor has it the runner images are now fixed... let's see. Fixes #6674
pow2clk
pushed a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Jul 16, 2024
This PR contains two changes: 1) Moves a pragma to disable a warning, which seems to be required by the new compiler. 2) Adds a preprocessor define to workaround the crashes caused by the runner image mismatching C++ runtime versions. The second change we will want to revert once the runner images are fixed. The issue tracking the runner images is: actions/runner-images#10004 Related microsoft#6668 (cherry picked from commit 0b9acdb)
pow2clk
pushed a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Jul 16, 2024
This removes the hack introduced in microsoft#6683 to workaround issues in the GitHub and ADO runner image: actions/runner-images#10004 Rumor has it the runner images are now fixed... let's see. Fixes microsoft#6674 (cherry picked from commit 98bb80a)
pow2clk
pushed a commit
that referenced
this pull request
Jul 16, 2024
Merges the following changes into mesh nodes to fix a known bug that required a point release in the march release branch and also some build fixes for new visual studio diagnostics. 9ca52f4 Add duplicate pragma (#6732) 7809c0b Remove Windows C++ redist hack (#6692) 33277a1 Workaround broken GitHub runner images (#6683) 1b9a796 [Sema] Check FunctionDecl has identifier before getName. (#6439) (#6457)
SjMxr233
pushed a commit
to ShaderHelper/DirectXShaderCompiler
that referenced
this pull request
Jul 24, 2025
This PR contains two changes: 1) Moves a pragma to disable a warning, which seems to be required by the new compiler. 2) Adds a preprocessor define to workaround the crashes caused by the runner image mismatching C++ runtime versions. The second change we will want to revert once the runner images are fixed. The issue tracking the runner images is: actions/runner-images#10004 Related microsoft#6668
SjMxr233
pushed a commit
to ShaderHelper/DirectXShaderCompiler
that referenced
this pull request
Jul 24, 2025
This removes the hack introduced in microsoft#6683 to workaround issues in the GitHub and ADO runner image: actions/runner-images#10004 Rumor has it the runner images are now fixed... let's see. Fixes microsoft#6674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
The second change we will want to revert once the runner images are fixed. The issue tracking the runner images is:
actions/runner-images#10004
Related #6668