Fix design time build error causing incremental build issue #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… project successfully builds due to rsp exists
kythant
approved these changes
Aug 16, 2025
glennawatson
pushed a commit
to reactiveui/ReactiveUI
that referenced
this pull request
Dec 14, 2025
…release.251115.2 (#4204) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [Microsoft.Windows.CsWinRT](https://redirect.github.com/microsoft/cswinrt) | `2.3.0-prerelease.251015.2` -> `2.3.0-prerelease.251115.2` |  |  | --- ### Release Notes <details> <summary>microsoft/cswinrt (Microsoft.Windows.CsWinRT)</summary> ### [`v2.3.0-prerelease.251115.2`](https://redirect.github.com/microsoft/CsWinRT/releases/tag/2.3.0-prerelease.251115.2): CsWinRT 2.3.0-prerelease.251115.2 This is a prerelease version of C#/WinRT with more bug fixes and improvements. **C#/WinRT package**: <https://www.nuget.org/packages/Microsoft.Windows.CsWinRT/2.3.0-prerelease.251115.2> #### What's Changed - Fix warning by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2023](https://redirect.github.com/microsoft/CsWinRT/pull/2023) - Use FormatMessage for exception messages in cases where the stowed/language exception doesn't contain a message by [@​ahmed605](https://redirect.github.com/ahmed605) in [microsoft/CsWinRT#2022](https://redirect.github.com/microsoft/CsWinRT/pull/2022) - Merge to staging/2.3 by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2025](https://redirect.github.com/microsoft/CsWinRT/pull/2025) - Merge staging/2.3 to master by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2030](https://redirect.github.com/microsoft/CsWinRT/pull/2030) - Fix 'Initialize' typo in several files by [@​Lightczx](https://redirect.github.com/Lightczx) in [microsoft/CsWinRT#2035](https://redirect.github.com/microsoft/CsWinRT/pull/2035) - Fix design time build error causing incremental build issue by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2036](https://redirect.github.com/microsoft/CsWinRT/pull/2036) - Move TestWinRT repo clone to resource by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2032](https://redirect.github.com/microsoft/CsWinRT/pull/2032) - Fix weak reference rehydration scenarios for non projected types by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2043](https://redirect.github.com/microsoft/CsWinRT/pull/2043) - Add UpToDateCheckBuilt to cover incremental build of Implementation dlls by [@​jevansaks](https://redirect.github.com/jevansaks) in [microsoft/CsWinRT#2051](https://redirect.github.com/microsoft/CsWinRT/pull/2051) - Fix issue where IReferenceArray is not being found by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2071](https://redirect.github.com/microsoft/CsWinRT/pull/2071) - Fix issue with unsubscribing from events on non-agile objects by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2079](https://redirect.github.com/microsoft/CsWinRT/pull/2079) - Fix issues with CopyToManagedArray by [@​manodasanW](https://redirect.github.com/manodasanW) in [microsoft/CsWinRT#2084](https://redirect.github.com/microsoft/CsWinRT/pull/2084) #### New Contributors - [@​ahmed605](https://redirect.github.com/ahmed605) made their first contribution in [microsoft/CsWinRT#2022](https://redirect.github.com/microsoft/CsWinRT/pull/2022) - [@​Lightczx](https://redirect.github.com/Lightczx) made their first contribution in [microsoft/CsWinRT#2035](https://redirect.github.com/microsoft/CsWinRT/pull/2035) **Full Changelog**: <microsoft/CsWinRT@2.3.0-prerelease.250720.1...2.3.0-prerelease.251115.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/reactiveui/ReactiveUI). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xNi4xIiwidXBkYXRlZEluVmVyIjoiNDIuMzIuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiRGVwZW5kZW5jeSBNYW5hZ2VtZW50Il19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If during design time build, we fail to generate a projection, we don't delete the
rspfiles as we configured it to continue on error and thereby theOnErrorhandler doesn't run. This can cause for the incremental build to report it succeeded based onrspand inputs not changing when it hasn't. Fixing it by having a separate way to delete therspfile for design time builds. Given we want the non-design time build to still stop on error, keepingOnErrortoo.