Fix non-blittable array marshaling #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manodasanW
commented
Jul 15, 2025
- Added AOT tests for more array scenarios including non-blittable arrays
- Enabled them for .NET 9 to validate non-blittable array support
- Enabled the non-blittable array support and made it not rely on Marshaler
Member
|
Out of curiosity, did you get any sizoscope diffs just to get an idea? I can also test with the Store if we can get a before/after build of this branch, but on top of my |
Sergio0694
approved these changes
Jul 16, 2025
46364a9
into
dev/disable-marshaler-t-aot
9 of 11 checks passed
manodasanW
added a commit
that referenced
this pull request
Jul 18, 2025
* Disable 'Marshaler<T>' on AOT * Update 'AsAgile' extension * Update 'StructTypeDetails<,>.GetNullableValue' * Add AOT annotations for 'Marshaler<T>' changes * Update non blittable 'BoxedValueIReferenceImpl<,>' * Update 'BoxedArrayIReferenceArrayImpl<T>' * Normalize whitespaces * Update MatchingRefApiCompatBaseline.net8.0.txt * Fix some warnings * Fix new AOT warnings * Use specialized marshallers for generic instantiations * Fix more generic instantiation cases * Make 'Marshaler' obsolete * Fix ILC warnings on 'IReferenceArray<T>' * Remove '[RequiresDynamicCode]' from 'Marshaler<T>' * Remove unnecessary '[Obsolete]' attribute * Tweak AOT checks * Fix non-blittable array marshaling (#2016) * Fix non bittable array marshaling * Move AOT tests to .NET 9 * Fix enums * Fix for .NET 9 * PR feedback --------- Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.