Remove .NET 6 target from all projects #1875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Nov 23, 2024
manodasanW
reviewed
Nov 23, 2024
Member
|
Looks like both host tests and wux tests are failing. I think the json in both needed to be updated: |
manodasanW
reviewed
Nov 24, 2024
manodasanW
reviewed
Nov 24, 2024
Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Member
|
This still says .NET 6 |
Member
|
The above might explain
|
Member
|
Those 3 still seem to be failing. |
manodasanW
reviewed
Nov 25, 2024
manodasanW
approved these changes
Nov 25, 2024
Sergio0694
added a commit
that referenced
this pull request
Dec 4, 2024
* Remove .NET 6 target from all projects * Update RIDs for .NET 8 * Bump .NET SDK in build script * Override RIDs for 'WinUIDesktopSample' project * Rename 'TestEmbedding' folders and files * Update readme files * Update runtimeconfig.json files * Throw if < .NET 8 is used for projections * Remove 'net7_0_or_greater' setting * Fix leftover options Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com> * Update RuntimeFrameworkVersion.csproj * Fix host tests * Add TFM check * Update src/WinRT.Runtime/WinRT.Runtime.csproj --------- Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes .NET 6 from all projects in the CsWinRT repo.