Skip interfaces not publicly accessible in authoring scenarios #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Nov 22, 2023
manodasanW
reviewed
Nov 22, 2023
| symbol is IEventSymbol @event && !@event.ExplicitInterfaceImplementations.IsDefaultOrEmpty) | ||
| { | ||
| // If we have a containing type, we also check that it's publicly accessible | ||
| return symbol.ContainingType is not { } containingType || containingType.IsPubliclyAccessible(); |
Member
There was a problem hiding this comment.
I am trying to understand this, should this have been an && rather than a || or am I misunderstanding what is not {} does.
Member
Author
There was a problem hiding this comment.
So, is not { } matches if the expression is not an instance (it's like is null, but also declares a local). So:
- If
containingTypeisnull, returntrue - Otherwise (ie.
containingType != null), returntrueif it's publicly accessible
If we used &&, we'd be trying to access containingType when the first expression already matched, but if that's the case, then containingType is not defined (because the expression matches on is not). In fact, if you changed it to &&, the code would just not compile, as containingType would be uninitialized in that case 🙂
manodasanW
approved these changes
Nov 22, 2023
manodasanW
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Add internal COM interfaces to authoring test * Add MixedWinRTClassicCOM authoring tests * Skip interface types not publicly accessible * Minor code refactoring * Suppress diagnostics for not publicly accessible types * Use fully qualified name for [Guid] to avoid conflicts * Remmove collection expressions in projection attributes * Skip processing explicit members of internal interfaces * Skip processing symbols nested in internal types * Add ABI types for AOT generator * Restore original order/filtering to gather interfaces * Fix build errors in AuthoringConsumptionTest * Add TestMixedWinRTCOMWrapper to activation manifest * Fix unit test * Fix typos in ABI method names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1369
Overview
This PR updates the WinRT authoring generator to skip interfaces that are not publicly accessible.