Handle async calls correctly in AotOptimizer #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
approved these changes
Nov 12, 2023
Member
|
Thanks for fixing this. |
jkoritzinsky
pushed a commit
to jkoritzinsky/CsWinRT
that referenced
this pull request
Dec 15, 2023
* Initial changes for addressing generic issue on AOT * Fix unittests and back compat * Fix compat issue * new line * Fix builds * Attempt to fix build * Fix build * Try to fix build * Fix restore. * Don't run AOT tests for x86 * Changes for generic support on AOT. * Make authoring scenarios AOT compatible * Covariance support * Add source generator reference * Add properties file * Support for arrays as objects and collections * Get event tests passing * Changes improving async operations and making function pointers blittable * Make generic handlers AOT friendly * Generic event handler improvements * Add async operation support, event support, and more generic type support. * Add missing attributes * Fix enumerator where certain scenarios such as arrays can return internal enumerators which we can't reference in source generator. * Fix issue where EnumeratorAdapter lookup table wasn't generated for all covariant interfaces. * Fix await scenarios * Fix bad merge * Update to .NET 8 SDK * Fix RIDs per .NET 8 breaking change and enable all AOT tests * Add IsAotCompatible property and increase timeout * Increase timeout * Fix crashes * Remove .NET 7 for now to address pipeline running out of space * Fix missing URI array marshaler * Handle scenario where vtable attribute is null due to no winrt interfaces. * Fix issue with exclusive overridable interfaces * Increase timeout * Fix discovered issues during validation * Code generate generic RCW methods for the specific instantiations used in the projections * Fix merge * Fix x86 builds * Run functional tests only for x86 on CI to avoid disk space issues * Fix restore * Fix test * PR feedback * Remove comment and fix disk space issue * Fix IStorageFolderHandleAccess and IStorageItemHandleAccess on AOT * Fix concurrent adds * Handle async calls correctly in AotOptimizer (microsoft#1383) * Handle async calls correctly in AotOptimizer * Enforce Async in name. * Add test * Fix issue with vtable lookup table being registered while the same thread is doing a read on it. * Fix casing for consistency * Fix build * Fix build out of space --------- Co-authored-by: Steve <hez2010@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of handling async calls from the await expression, we need to handle it from the invocation expression.
Because an async call is not necessarily to be awaited directly.