Skip to content

Conversation

@compulim
Copy link
Contributor

@compulim compulim commented Sep 14, 2023

Fixes #4853.

Changelog Entry

Added

Description

URLs without title will be shorten for readability. See #4853 for rules.

Design

If the URL is intuitive enough, we will shorten it.

Signals of intuitiveness: http/https, default protocol, starts with www.

Specific Changes

  • Added shortenURL to shorten URLs
  • Updated link definition item to shorten URL if title is not available
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review September 14, 2023 22:37
@compulim compulim force-pushed the feat-4853-shorten-url branch from f62f18b to 8c1fdba Compare September 15, 2023 00:05
beyackle2
beyackle2 previously approved these changes Sep 15, 2023
Copy link

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit 155aecd into main Sep 15, 2023
@compulim compulim deleted the feat-4853-shorten-url branch September 15, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown: links without title could display shortened host name

4 participants