Skip to content

Conversation

@compulim
Copy link
Contributor

@compulim compulim commented Feb 21, 2023

Related to #4643.

Changelog Entry

Added

  • Resolved #4643. Decoupling botframework-directlinejs from business logic of Web Chat for better tree-shaking, by @compulim, in PR #4645 and PR #4648

Description

This is to test an imminent release that would target two areas:

  • Customize aria-label for left/right flipper
  • Avoided global pollution of core-js

Once this looks good, we will create another pull request to bump to production release.

Specific Changes

  • Bump react-film to @3.1.1-main.df870ea
    • Added
      • Added leftFlipperAriaLabel and rightFlipperAriaLabel for customizing the aria-label attribute for flipper buttons, by @compulim, in PR #98
    • Changes
      • Avoided global pollution via @babel/runtime-corejs3, by @compulim, in PR #99
      • Bundle is now built using Webpack for compatibility with IE Mode, by @compulim, in PR #99
      • Bump dependencies, by @compulim, in PR #99
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • ~Browser and platform compatibilities reviewed`
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review February 22, 2023 18:56
@compulim compulim merged commit b8435f4 into main Feb 22, 2023
@compulim compulim deleted the bump-react-film branch February 22, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tree shaking] Decouple botframework-directlinejs

3 participants