Debump Speech SDK to 1.17.0 #4533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
approved these changes
Nov 29, 2022
beyackle2
pushed a commit
that referenced
this pull request
Dec 1, 2022
* Debump Speech SDK to 1.17.0 * Update entry * Debump Speech SDK 1.17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
microsoft-cognitiveservices-speech-sdk@1.17.0, by @compulim in PR #4533web-speech-cognitive-services@7.1.3Description
In some recent versions of
microsoft-cognitiveservices-speech-sdk(a.k.a. Speech SDK), they are having some issues with non-npmpackage manager, such asyarnorpnpm.They will fix the issue in January 2023 release. However, to unblock our current customers, we need to debump it back to a known good version (1.17.0).
When we perform manual release testing, we need to make sure Web Chat works with
yarnand/orpnpm.Design
microsoft-cognitiveservices-speech-sdk/package.jsonhas apreinstallscript which only works withnpmbut notyarnorpnpm. They are using this special script fornpm-force-resolutions.In the next release of Speech SDK, they will fix the issue by two changes:
package.json/overridesand is also adopted bypnpmovernpm-force-resolutionspreinstallscript tosetup, which should not run on normalnpm installoperationToday, to unblock our customers, we need to debump Speech SDK back to 1.17.0.
Specific Changes
npm install --save-exact microsoft-cognitiveservices-speech-sdk@1.17.0 web-speech-cognitive-services@7.1.4underpackages/bundleandpackages/directlinespeechCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)