Skip to content

[Post 4.10.1] Add sample for activity grouping #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
compulim merged 7 commits into from
Oct 27, 2020
Merged

[Post 4.10.1] Add sample for activity grouping #3415

compulim merged 7 commits into from
Oct 27, 2020

Conversation

@compulim
Copy link
Contributor

@compulim compulim commented Aug 14, 2020 •
edited
Loading

Fixes #2939.

Changelog Entry

Samples

Description

Added a sample for activity grouping.

Specific Changes

  • Added index.html and README.md for 02.branding-styling-and-customization/j.activity-grouping
  • I have added tests and executed them locally
    • Not apply to samples
  • I have updated CHANGELOG.md
  • I have updated documentation (samples/README.md)

Review Checklist

This section is for contributors to review your work.

(Crossed out items not apply to this pull request)

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Tests reviewed (coverage, legitimacy)

@compulim compulim force-pushed the fix-2939-sample branch 2 times, most recently from 2ab5a55 to dd0d1a5 Compare August 20, 2020 22:31
cwhitten
cwhitten reviewed Aug 22, 2020
View reviewed changes
@compulim compulim changed the title Add sample for activity grouping [Post 4.10.1] Add sample for activity grouping Sep 3, 2020
@corinagum
Copy link
Contributor

corinagum commented Sep 23, 2020

ping

compulim and others added 3 commits October 26, 2020 16:46
compulim
compulim commented Oct 26, 2020
View reviewed changes
compulim
compulim commented Oct 26, 2020
View reviewed changes
corinagum
corinagum approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit 4d07bfd into microsoft:master Oct 27, 2020
@compulim compulim deleted the fix-2939-sample branch October 27, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwhitten cwhitten cwhitten left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

+1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compulim compulim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OC: Timestamp and avatar grouping (Jul 1)

3 participants

@compulim @corinagum @cwhitten