Remove EmptyApp tests as its covered eslewhere#2025
Merged
cijothomas merged 4 commits intodevelopfrom Sep 3, 2020
Merged
Conversation
TimothyMothra
approved these changes
Sep 3, 2020
|
Need to remove it from the Everything.sln as well |
…soft/ApplicationInsights-dotnet into cijothomas/aspnetcoretest4
eddynaka
added a commit
that referenced
this pull request
Sep 4, 2020
changing to ubuntu-latest (18.04 for now) reverting moving to ubuntu-latest Remove EmptyApp tests as its covered eslewhere (#2025) * Remove EmptyApp tests as its covered eslewhere * cleanup Ingestion service data delivery status (#1887) * Added eventhandler to transmission * Updated public API * Modified changelog.md * Added more tests * Fix API * Added coverage for timeout * Update to API * Modified comment in transmission. * PR Comments * PR feedback * Fix test * Added TransmissionStatusEvent to InMemoryChannel. * Remove Inmemory change Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026) * Refactor tests and fix several issues in one go * remove unwanted changes * update changelog Co-authored-by: Timothy Mothra Lee <tilee@microsoft.com> changing to posix updating orderby
eddynaka
added a commit
that referenced
this pull request
Sep 4, 2020
changing to ubuntu-latest (18.04 for now) reverting moving to ubuntu-latest Remove EmptyApp tests as its covered eslewhere (#2025) * Remove EmptyApp tests as its covered eslewhere * cleanup Ingestion service data delivery status (#1887) * Added eventhandler to transmission * Updated public API * Modified changelog.md * Added more tests * Fix API * Added coverage for timeout * Update to API * Modified comment in transmission. * PR Comments * PR feedback * Fix test * Added TransmissionStatusEvent to InMemoryChannel. * Remove Inmemory change Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026) * Refactor tests and fix several issues in one go * remove unwanted changes * update changelog Co-authored-by: Timothy Mothra Lee <tilee@microsoft.com> changing to posix updating orderby
eddynaka
added a commit
that referenced
this pull request
Sep 4, 2020
changing to ubuntu-latest (18.04 for now) reverting moving to ubuntu-latest Remove EmptyApp tests as its covered eslewhere (#2025) * Remove EmptyApp tests as its covered eslewhere * cleanup Ingestion service data delivery status (#1887) * Added eventhandler to transmission * Updated public API * Modified changelog.md * Added more tests * Fix API * Added coverage for timeout * Update to API * Modified comment in transmission. * PR Comments * PR feedback * Fix test * Added TransmissionStatusEvent to InMemoryChannel. * Remove Inmemory change Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026) * Refactor tests and fix several issues in one go * remove unwanted changes * update changelog Co-authored-by: Timothy Mothra Lee <tilee@microsoft.com> changing to posix updating orderby removing unused usings and space
eddynaka
added a commit
that referenced
this pull request
Sep 4, 2020
changing to ubuntu-latest (18.04 for now) reverting moving to ubuntu-latest Remove EmptyApp tests as its covered eslewhere (#2025) * Remove EmptyApp tests as its covered eslewhere * cleanup Ingestion service data delivery status (#1887) * Added eventhandler to transmission * Updated public API * Modified changelog.md * Added more tests * Fix API * Added coverage for timeout * Update to API * Modified comment in transmission. * PR Comments * PR feedback * Fix test * Added TransmissionStatusEvent to InMemoryChannel. * Remove Inmemory change Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026) * Refactor tests and fix several issues in one go * remove unwanted changes * update changelog Co-authored-by: Timothy Mothra Lee <tilee@microsoft.com> changing to posix updating orderby removing unused usings and space updating trx folder path udoing
cijothomas
pushed a commit
that referenced
this pull request
Sep 4, 2020
changing to ubuntu-latest (18.04 for now) reverting moving to ubuntu-latest Remove EmptyApp tests as its covered eslewhere (#2025) * Remove EmptyApp tests as its covered eslewhere * cleanup Ingestion service data delivery status (#1887) * Added eventhandler to transmission * Updated public API * Modified changelog.md * Added more tests * Fix API * Added coverage for timeout * Update to API * Modified comment in transmission. * PR Comments * PR feedback * Fix test * Added TransmissionStatusEvent to InMemoryChannel. * Remove Inmemory change Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026) * Refactor tests and fix several issues in one go * remove unwanted changes * update changelog Co-authored-by: Timothy Mothra Lee <tilee@microsoft.com> changing to posix updating orderby removing unused usings and space updating trx folder path udoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue # .
Changes
(Please provide a brief description of the changes here.)
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build