Skip to content

command name string comparison case insensitive#940

Merged
littleaj merged 2 commits into
microsoft:masterfrom
philoushka:patch-1
May 30, 2019
Merged

command name string comparison case insensitive#940
littleaj merged 2 commits into
microsoft:masterfrom
philoushka:patch-1

Conversation

@philoushka

@philoushka philoushka commented May 29, 2019

Copy link
Copy Markdown
Contributor

Make the Explain query string comparison continue regardless of the casing (upper, lower, mixed) for a statement starting with SELECT.

Fix #907 .

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated

Make the Explain query string comparison continue regardless of the casing (upper, lower, mixed) for a statement starting with `SELECT`.
@littleaj littleaj requested review from littleaj and trask May 29, 2019 22:41
@littleaj

Copy link
Copy Markdown
Contributor

@philoushka Please update CHANGELOG.md in the root of the repo following the current convention (link to issue + short description of fix)

@littleaj

Copy link
Copy Markdown
Contributor

but other than that, it looks pretty straightforward. It should be good to merge after a successful build.

@philoushka

Copy link
Copy Markdown
Contributor Author

Thanks @littleaj , just wasn't sure which section within changelog.md to put an entry into... my initial guess would be the section for Version 2.4.0? Please give this a thumbs up if that's correct, or let me know if incorrect.

@littleaj

Copy link
Copy Markdown
Contributor

/AzurePipelines run AppInsights-Java-Gradle-CI

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@msftclas

msftclas commented May 29, 2019

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@littleaj

Copy link
Copy Markdown
Contributor

/AzurePipelines help

@azure-pipelines

Copy link
Copy Markdown
Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or a specific pipeline for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify a pipeline to run.
    • Example: "run" or "run pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littleaj

Copy link
Copy Markdown
Contributor

@trask, the build trigger worked!

@littleaj littleaj merged commit 9cca059 into microsoft:master May 30, 2019
@littleaj

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @philoushka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JDBC Telemetry on explain plan is filter on uppercase "SELECT" only

4 participants