Fix duplicate pc jni#920
Merged
Merged
Conversation
using StringUtils instead of guava Strings.
prevent null dereference
trask
approved these changes
May 3, 2019
trask
pushed a commit
that referenced
this pull request
Sep 21, 2020
* Add instrumentation for Armeria WebClient. * Format: * httpurlconnection * Docs and consistency:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #919 - If the PC was already registered, then return the key as if it was just registered. This doesn't seem like an error case to me.
Also, I removed dependency on guava (we don't depend on it directly).
Updated clean build task to delete JNI DLL from tmpdir so it always uses the newly built DLL after a clean.
Includes some logging clean up, too.