Skip to content

Fixed closable resources#847

Merged
littleaj merged 12 commits into
masterfrom
fixResources
Mar 13, 2019
Merged

Fixed closable resources#847
littleaj merged 12 commits into
masterfrom
fixResources

Conversation

@littleaj

Copy link
Copy Markdown
Contributor

Several Closable resources were either left open or incorrectly closed.

@littleaj littleaj requested a review from dhaval24 March 13, 2019 00:58
if (file == null) {
return Optional.absent();
}
try (ObjectInput input = new ObjectInputStream(new BufferedInputStream(new FileInputStream(file)))) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@dhaval24 dhaval24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleanup

@littleaj littleaj merged commit 47c017b into master Mar 13, 2019
@littleaj littleaj deleted the fixResources branch March 13, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants