Add checkstyle.xml, idea-style guide (For importing in IDE) and enabl…#778
Merged
Conversation
…ing checkstyle in build
reyang
approved these changes
Dec 3, 2018
| <module name="SuppressionCommentFilter"/> | ||
| </module> | ||
| <module name="SuppressWarningsFilter"/> | ||
| </module> No newline at end of file |
Member
There was a problem hiding this comment.
Do we want an empty line before EOF?
Contributor
Author
There was a problem hiding this comment.
@reyang What is the general practice you have seen in other projects? I am fine with having one.
Member
There was a problem hiding this comment.
General practice is to add empty line before EOF.
littleaj
suggested changes
Dec 4, 2018
Contributor
Author
|
@littleaj can we conclude on this PR today? Let me know if there are additional things in your mind. |
Contributor
Author
|
@littleaj can you please approve this PR. All your comments are now resolved. We should be good to merge this. |
littleaj
approved these changes
Dec 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CheckStyle rules.
Related #490 #694
@littleaj let's review the rules here so we can make a bulk change in the whole SDK.