Skip to content

Set up JaCoCo Code Coverage, update Gradle wrapper#756

Merged
dhaval24 merged 5 commits into
masterfrom
AddCodeCov
Oct 2, 2018
Merged

Set up JaCoCo Code Coverage, update Gradle wrapper#756
dhaval24 merged 5 commits into
masterfrom
AddCodeCov

Conversation

@dhaval24

Copy link
Copy Markdown
Contributor

This PR sets up JaCoCo code coverage, updates Gradle wrapper to 4.2 (updating beyond this fails native linking), fixes build.gradle file for web module and cleans some imports in tests.

@dhaval24 dhaval24 requested review from grlima and littleaj and removed request for littleaj October 1, 2018 15:44
@dhaval24

dhaval24 commented Oct 1, 2018

Copy link
Copy Markdown
Contributor Author

Currently this creates separete coverage reports. I am experimenting to ultimately have one single report generated for all projects

Comment thread web/build.gradle
littleaj
littleaj previously approved these changes Oct 1, 2018

@littleaj littleaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to explore options other than using common-java.gradle for add the code coverage

@littleaj littleaj dismissed their stale review October 1, 2018 23:57

see above comment

@dhaval24

dhaval24 commented Oct 2, 2018

Copy link
Copy Markdown
Contributor Author

@littleaj tried to play around a bit after you left, seems like xml is not getting generated somehow by moving to the subprojects. Also it's not picking the specified version of Jacoco. I think that subprojects closure is not being used at all. Its just picking up the default configuration of jacoco. We might for now just keep it into commons-java file and later experiment.

@dhaval24

dhaval24 commented Oct 2, 2018

Copy link
Copy Markdown
Contributor Author

@littleaj as mentioned, in the comment above, I have reverted your commit to ensure that xml's are being generated. I think we can be satisfied with this for now and later on move experiment more for combined report. Let me know your thoughts.

@littleaj

littleaj commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

That makes sense. I guess we'll use the import file for now.

@dhaval24 dhaval24 self-assigned this Oct 2, 2018
@dhaval24 dhaval24 merged commit 891f6e6 into master Oct 2, 2018
@dhaval24 dhaval24 deleted the AddCodeCov branch October 2, 2018 18:15
@littleaj littleaj restored the AddCodeCov branch October 2, 2018 18:50
littleaj added a commit that referenced this pull request Oct 2, 2018
@trask trask deleted the AddCodeCov branch September 21, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants