Apply exception type and message#3148
Merged
Merged
Conversation
jeanbisutti
reviewed
Jun 21, 2023
Contributor
Author
|
smoke test didn't work. i'll wait for trask's feedback then. |
Contributor
Author
|
note: customer is happy with this fix. |
trask
reviewed
Jun 27, 2023
trask
reviewed
Jun 27, 2023
trask
reviewed
Jun 27, 2023
Contributor
Author
|
@trask added smoke test, please check it out |
trask
reviewed
Jun 27, 2023
trask
reviewed
Jun 27, 2023
Contributor
Author
|
have you checked out the smoke test? what is the risk of not having smoke test for this? |
trask
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing is done here