Fixing URL generation from file path.#287
Merged
Merged
Conversation
Appending 'file:/' at the start of a file path work only under windows, where paths start with the drive letter (-> file:/c:/...). On Unix, paths start with /, resulting in a URL like file://var/lib/... - this is then interpreted as a file on the host 'var', in directory 'lib/...' This fix utilizes Java to source the URL for a file, instead of crafting it manually.
|
Hi @SFThomas, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@SFThomas, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appending 'file:/' at the start of a file path works only under windows, where paths start with the drive letter (-> file:/c:/...).
On Unix, paths start with /, resulting in a URL like file://var/lib/... - this is then interpreted as a file on the host 'var', in directory 'lib/...'
This fix utilizes Java to source the URL for a file, instead of crafting it manually.