Fix OFF logging threshold#2592
Merged
Merged
Conversation
jeanbisutti
reviewed
Oct 13, 2022
| } | ||
|
|
||
| public static Severity getSeverity(String level) { | ||
| public static int getSeverityThreshold(String level) { |
Contributor
There was a problem hiding this comment.
(suggestion) This method might be moved in AgentLogExporter and called around line 84. So all the log logic would be in the place where we need it. A boolean exportLog(LogData log, String configuredLogThreshold) method might then be added and contains all the log level logic for the export. The configuration object would then represent the log level as a string an not an int.
Member
Author
There was a problem hiding this comment.
this looks a bit more challenging, as we are also using this method for fail-fast validation of the configuration:
heyams
approved these changes
Oct 13, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2590