Fix sampling for custom instrumentation#2513
Merged
Merged
Conversation
c238ba1 to
401423d
Compare
401423d to
7b6f48d
Compare
trask
commented
Sep 12, 2022
2c6e355 to
7b6f48d
Compare
heyams
reviewed
Sep 12, 2022
| @@ -0,0 +1,3 @@ | |||
| This is a copy of the upstream methods instrumentation module, but changed to emit SERVER spans | |||
Contributor
There was a problem hiding this comment.
can we add this note to MethodSingletons class? it used SpanKindExtractor.alwaysServer(). and then delete this readme?
| // Licensed under the MIT License. | ||
|
|
||
| package io.opentelemetry.javaagent.instrumentation.micrometer; | ||
| package io.opentelemetry.javaagent.instrumentation.micrometer.ai; |
Contributor
There was a problem hiding this comment.
upstream adds a new package for app insights specifically?
Member
Author
There was a problem hiding this comment.
no, this is to avoid conflicting with upstream's package name (which already uses io.opentelemetry.javaagent.instrumentation.micrometer)
heyams
reviewed
Sep 13, 2022
| import net.bytebuddy.implementation.bytecode.assign.Assigner; | ||
| import net.bytebuddy.matcher.ElementMatcher; | ||
|
|
||
| public class MethodInstrumentation implements TypeInstrumentation { |
Contributor
There was a problem hiding this comment.
can we make a note that this is a temporary solution and long-term solution upstream might be feasible in the near future?
Contributor
There was a problem hiding this comment.
is this identical to upstream methodInstrumentation?
Member
Author
There was a problem hiding this comment.
I have created a work item for long-term solution
| properties.put("otel.instrumentation.log4j-context-data.enabled", "true"); | ||
| properties.put("otel.instrumentation.logback-mdc.enabled", "true"); | ||
| properties.put("otel.instrumentation.methods.enabled", "true"); | ||
| properties.put("otel.instrumentation.ai-methods.enabled", "true"); |
Contributor
There was a problem hiding this comment.
…om-instrumentation
Merged
heyams
approved these changes
Sep 15, 2022
heyams
pushed a commit
that referenced
this pull request
Sep 16, 2022
heyams
pushed a commit
that referenced
this pull request
Sep 16, 2022
heyams
pushed a commit
that referenced
this pull request
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.