Skip to content

Turn off Statsbeat when proxy is used or any exception from the server#2221

Merged
trask merged 17 commits into
mainfrom
heya/fix-statsbeat
Apr 13, 2022
Merged

Turn off Statsbeat when proxy is used or any exception from the server#2221
trask merged 17 commits into
mainfrom
heya/fix-statsbeat

Conversation

@heyams

@heyams heyams commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@heyams heyams requested a review from trask as a code owner April 7, 2022 19:53

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask self-requested a review April 8, 2022 20:37

@hectorhdzg hectorhdzg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trask

trask commented Apr 9, 2022

Copy link
Copy Markdown
Member

@heyams @hectorhdzg I pushed some changes:

  • suppress all logging of statsbeat telemetry failures (introduced a noop logger to make this easier, there were many additional places that would have needed to be wrapped in conditionals)
  • if statsbeat is shut down, then stop sending statsbeat telemetry from disk (which will likely keep failing and getting stored back to disk every 30 seconds until they expire after 2 days)
  • shut down statsbeat if the first X statsbeat ingestions requests all fail for any reason other than throttling (439/402), and removed the special case for http proxy
    • I believe this is both simpler than special casing for http proxy, and will cover potentially other unknown environmental limitations that we may be unaware of currently

@heyams

heyams commented Apr 13, 2022

Copy link
Copy Markdown
Contributor Author

Approved.

@trask trask merged commit 9361d1d into main Apr 13, 2022
@trask trask deleted the heya/fix-statsbeat branch April 13, 2022 03:42
trask added a commit that referenced this pull request Apr 14, 2022
* Add scheduled delay for batch span processor (#2222)

* Turn off Statsbeat when proxy is used or any exception from the server (#2221)

* Turn off statsbeat when proxy used or any exception from the server

* Fix comment format

* Add a todo

* Address feedback

* Change todo

* Shut down after 3 statsbeat errors

* Reset statsbeat error count on success

* Use one time success flag and increment max to 10

* No need to reset

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Suppress statbeat error logging

* Simplify and avoid other unknown cases

* move and comment

* one more logging

* Update to latest spec PR

* imports

* Add comment

* Add TODO

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Release 3.2.11 (#2227)

* Prepare for the new release

* Reword

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* spotless

* update

Co-authored-by: Helen <56097766+heyams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants