Log ingestion error on 206 response#2065
Merged
Merged
Conversation
Member
Author
|
if you hide whitespace in the diff it will help |
heyams
reviewed
Jan 22, 2022
| case 500: // INTERNAL SERVER ERROR | ||
| case 503: // SERVICE UNAVAILABLE | ||
| case 429: // TOO MANY REQUESTS | ||
| // TODO (heya) should we write to disk on any of these response codes? |
Contributor
There was a problem hiding this comment.
not sure... if we don't write to disk, we should consider tracking how many requests we drop. Let's think about it.. need to come up with new property in customdimension.. it can be part of network statsbeat..
Contributor
There was a problem hiding this comment.
can you update the todo to track data drop via statsbeat?
heyams
approved these changes
Jan 24, 2022
trask
commented
Jan 24, 2022
Comment on lines
+305
to
+314
| case 408: // REQUEST TIMEOUT | ||
| case 429: // TOO MANY REQUESTS | ||
| case 500: // INTERNAL SERVER ERROR | ||
| case 503: // SERVICE UNAVAILABLE | ||
| operationLogger.recordFailure( | ||
| "received response code " | ||
| + statusCode | ||
| + " (telemetry will be stored to disk and retried later)"); | ||
| onFailure.accept(true); | ||
| break; |
Member
Author
There was a problem hiding this comment.
this is the list of response codes that 2.x used to retry on, I think it's a good list, not sure when we diverged from it
heyams
reviewed
Jan 25, 2022
heyams
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2064, which we never noticed since we didn't log it.
Now the error in #2064 would be logged as: