Updating projects build & upload separated jars#20
Merged
Conversation
Contributor
There was a problem hiding this comment.
Actually I think adding the logging level was a good idea.
Why should we change it?
(one possible answer can be that .Net logging does not have this level)
Contributor
There was a problem hiding this comment.
However, I'm not sure at all that logging.common should become to the general applicationinsights common so this might be a consideration against this change.
trask
pushed a commit
that referenced
this pull request
Apr 22, 2021
* Instrumenter * Spotless * More instrumenter * More * Instrumenter API * New Instrumenter API - InstrumenterBuilder (#20) * New Instrumenter API - InstrumenterBuilder * New Instrumenter API - InstrumenterBuilder - code review comments * Start doccing * Docs * Most tests * Last test * Stick with current hostName lookup for now * Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpClientTest.groovy Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com> * New Instrumenter API - code review comments (#21) * Doc * Checkstyle * Cleanups Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
trask
pushed a commit
that referenced
this pull request
Apr 22, 2021
* Instrumenter * Spotless * More instrumenter * More * Instrumenter API * New Instrumenter API - InstrumenterBuilder (#20) * New Instrumenter API - InstrumenterBuilder * New Instrumenter API - InstrumenterBuilder - code review comments * Start doccing * Docs * Most tests * Last test * Stick with current hostName lookup for now * Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpClientTest.groovy Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com> * New Instrumenter API - code review comments (#21) * Doc * Checkstyle * Cleanups Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
trask
pushed a commit
that referenced
this pull request
May 26, 2021
* Instrumenter * Spotless * More instrumenter * More * Instrumenter API * New Instrumenter API - InstrumenterBuilder (#20) * New Instrumenter API - InstrumenterBuilder * New Instrumenter API - InstrumenterBuilder - code review comments * Start doccing * Docs * Most tests * Last test * Stick with current hostName lookup for now * Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpClientTest.groovy Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com> * New Instrumenter API - code review comments (#21) * Doc * Checkstyle * Cleanups Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating projects to build and upload separated jars that currently include the 'core' and appenders (jar per appender).
Few things so the CR will be more easy to understand:
The above means that you may ignore all the 'move' changes (there's nothing to see there actually) and focus on the build files.