Track disk IO via Non-essential statsbeat#1925
Conversation
trask
left a comment
There was a problem hiding this comment.
instead of the latest change which seems to have complicated things a bit, how about injecting NonessentialStatsbeat into the LocalFileLoader, and then you can have more fine-grained control of logging failures directly inside of loadTelemetriesFromDisk()
that was my first attempt and later realized it's less code change doing this way. it just eliminates one case where failure count doesn't apply. Loader is the only place where loadTelemetriesFromDisk is called disregarding tests. |
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
|
@ramthi can you take a look at it again? you're currently blocking the merge. i have addressed all your comments. thanks. |
No description provided.