Skip to content

Track disk IO via Non-essential statsbeat#1925

Merged
heyams merged 24 commits into
mainfrom
heya/statsbeat
Oct 27, 2021
Merged

Track disk IO via Non-essential statsbeat#1925
heyams merged 24 commits into
mainfrom
heya/statsbeat

Conversation

@heyams

@heyams heyams commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@heyams heyams marked this pull request as ready for review October 22, 2021 22:01

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of the latest change which seems to have complicated things a bit, how about injecting NonessentialStatsbeat into the LocalFileLoader, and then you can have more fine-grained control of logging failures directly inside of loadTelemetriesFromDisk()

@heyams

heyams commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

instead of the latest change which seems to have complicated things a bit, how about injecting NonessentialStatsbeat into the LocalFileLoader, and then you can have more fine-grained control of logging failures directly inside of loadTelemetriesFromDisk()

that was my first attempt and later realized it's less code change doing this way. it just eliminates one case where failure count doesn't apply. Loader is the only place where loadTelemetriesFromDisk is called disregarding tests.

heyams and others added 3 commits October 27, 2021 11:46
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@heyams

heyams commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

@ramthi can you take a look at it again? you're currently blocking the merge. i have addressed all your comments. thanks.

@heyams heyams requested a review from ramthi October 27, 2021 20:46
@heyams heyams merged commit 1ded29a into main Oct 27, 2021
@heyams heyams deleted the heya/statsbeat branch October 27, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants