Skip to content

Fix netty ByteBuf leak#1822

Merged
trask merged 2 commits into
mainfrom
fix-byte-buf-leak
Aug 2, 2021
Merged

Fix netty ByteBuf leak#1822
trask merged 2 commits into
mainfrom
fix-byte-buf-leak

Conversation

@trask

@trask trask commented Jul 31, 2021

Copy link
Copy Markdown
Member

Fixes an issue that started in 3.2.0-BETA.1 after swapping out ingestion http client with Azure SDK / reactor netty.

ERROR io.netty.util.ResourceLeakDetector - LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.

This was referenced Jul 31, 2021
Merged
Merged
heyams
heyams approved these changes Jul 31, 2021
View reviewed changes

@heyams heyams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 8349df0 into main Aug 2, 2021
@trask trask deleted the fix-byte-buf-leak branch August 2, 2021 21:33
@kryalama kryalama added this to the 3.2.0-BETA.3 milestone Sep 3, 2021
@trask trask mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiao-lix xiao-lix Awaiting requested review from xiao-lix

2 more reviewers

@heyams heyams heyams approved these changes

@kryalama kryalama kryalama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2.0-BETA.3

Development

Successfully merging this pull request may close these issues.

3 participants

@trask @heyams @kryalama