Use envelope name as the telemetry name and reduce payload#1700
Merged
Conversation
trask
reviewed
May 20, 2021
trask
left a comment
Member
There was a problem hiding this comment.
👍👍 can we make this in aad branch instead? since the implementation will be different over there, and not in a rush for this change
Contributor
Author
|
don't we want to use the shorter telemetry name in the master branch? I can cherry-pick into the aad branch. |
Member
|
trying to reduce merge conflicts by limiting non-critical work in the master branch. planning to get the aad branch finished and merged into master in the next month or two. |
trask
approved these changes
May 20, 2021
trask
pushed a commit
that referenced
this pull request
Jun 22, 2021
* Use envelope name as the telemetry name * Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9860567
sample envelopes with this change:
