Fix for jdbc target and duplicate headers#1647
Merged
Merged
Conversation
heyams
approved these changes
Apr 22, 2021
| return 6379; | ||
| case SemanticAttributes.DbSystemValues.MARIADB: | ||
| case SemanticAttributes.DbSystemValues.MYSQL: | ||
| return 3306; |
Contributor
There was a problem hiding this comment.
Does otel-java have constants for these ports? It will be nice if they do. Or also where is the spec for defining these port numbers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update otel fork submodule, see: #1645
Updates Jdbc smoke tests due to the new (better) target attribute.
Fixes an unrelated issue where the Jdbc smoke tests just started failing due to recent update in mysql image that requires enabling TLSv1.3 in the driver
Resolves #1640
Attaching SNAPSHOT release from this PR: applicationinsights-agent-3.0.4-BETA-SNAPSHOT.jar.zip