Skip to content

Roles Support in QuickPulse Java SDK#1510

Merged
trask merged 14 commits into
microsoft:masterfrom
rambhatt-msft:master
Mar 2, 2021
Merged

Roles Support in QuickPulse Java SDK#1510
trask merged 14 commits into
microsoft:masterfrom
rambhatt-msft:master

Conversation

@rambhatt-msft

@rambhatt-msft rambhatt-msft commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

Fix # .

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated

@rambhatt-msft rambhatt-msft marked this pull request as ready for review February 25, 2021 01:05
@rambhatt-msft rambhatt-msft changed the title [WIP] Roles Support in QuickPulse Java SDK Roles Support in QuickPulse Java SDK Feb 25, 2021

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rambhatt-msft, this is looking great!

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will wait for your confirmation before merging

@rambhatt-msft

Copy link
Copy Markdown
Contributor Author

👍 will wait for your confirmation before merging

I am ready with the change. @tokaplan when you feel comfortable with it, we can merge.

@trask

trask commented Mar 2, 2021

Copy link
Copy Markdown
Member

devops please run

@trask

trask commented Mar 2, 2021

Copy link
Copy Markdown
Member

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@trask

trask commented Mar 2, 2021

Copy link
Copy Markdown
Member

/AzurePipelines run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@trask trask merged commit a636e29 into microsoft:master Mar 2, 2021
@trask

trask commented Mar 2, 2021

Copy link
Copy Markdown
Member

Thanks @rambhatt-msft!

@rambhatt-msft

Copy link
Copy Markdown
Contributor Author

Thanks @rambhatt-msft!

Thank for approving @trask 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants