Configuration file related changes#1459
Merged
Merged
Conversation
trask
reviewed
Jan 25, 2021
trask
left a comment
Member
There was a problem hiding this comment.
does the user see a friendly message on invalid json attribute?
Comment on lines
+140
to
+142
| } catch (URISyntaxException e) { | ||
| e.printStackTrace(); | ||
| } finally { |
Member
There was a problem hiding this comment.
Suggested change
| } catch (URISyntaxException e) { | |
| e.printStackTrace(); | |
| } finally { | |
| } catch (Throwable e) { | |
| e.printStackTrace(); |
Comment on lines
+143
to
+150
| // If the startupLogger still have some issues being initialized, just print the error stack trace | ||
| if(startupLogger == null) { | ||
| if (isFriendlyException) { | ||
| System.err.println(message); | ||
| } else { | ||
| t.printStackTrace(); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| // If the startupLogger still have some issues being initialized, just print the error stack trace | |
| if(startupLogger == null) { | |
| if (isFriendlyException) { | |
| System.err.println(message); | |
| } else { | |
| t.printStackTrace(); | |
| } | |
| } | |
| if (isFriendlyException) { | |
| System.err.println(message); | |
| } else { | |
| t.printStackTrace(); | |
| } |
| try (InputStream in = Files.newInputStream(configPath)) { | ||
| Moshi moshi = MoshiBuilderFactory.createBuilderWithAdaptor(); | ||
| JsonAdapter<Configuration> jsonAdapter = moshi.adapter(Configuration.class); | ||
| JsonAdapter<Configuration> jsonAdapter = moshi.adapter(Configuration.class).failOnUnknown(); |
Contributor
Author
I was thinking to handle this in a new PR. I will create a work item for this. |
trask
approved these changes
Jan 26, 2021
| "selfDiagnostics": { | ||
| "level": "debug" | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements:
Improve discoverability of configuration file syntax error
Fail on invalid config attributes instead of silently ignoring