fix classifier added by 'shadow' configuration#1200
Merged
Conversation
trask
pushed a commit
that referenced
this pull request
Oct 17, 2020
* Implement MDC auto-instrumentation for log4j2 * Implement MDC auto-instrumentation for log4j2 2.7 * Implement MDC auto-instrumentation for log4j2 * Implement MDC auto-instrumentation for log4j2 * Implement MDC auto-instrumentation for log4j2 * Implement MDC auto-instrumentation for log4j1 * Implement MDC auto-instrumentation for log4j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1199.
Introduced by this change: c898d49
Apparently the 'shadow' configuration (defined by the shadowJar plugin) adds the 'all' classifier to the dependency in the pom by default.
Using the shadow configuration as a dependency simplifies the build script and prevents the need to change the spring-boot-starter build file if web or core dependencies change.
For significant contributions please make sure you have completed the following items: