docs: document Jakarta Mail instrumentation#7256
Merged
shakuzen merged 1 commit intomicrometer-metrics:1.16.xfrom Mar 9, 2026
Merged
docs: document Jakarta Mail instrumentation#7256shakuzen merged 1 commit intomicrometer-metrics:1.16.xfrom
shakuzen merged 1 commit intomicrometer-metrics:1.16.xfrom
Conversation
shakuzen
approved these changes
Mar 9, 2026
Member
shakuzen
left a comment
There was a problem hiding this comment.
Thank you. Looks good to me. I'll rebase onto 1.16.x and follow-up with a minor polishing.
| ** xref:reference/jms.adoc[JMS] | ||
| ** xref:reference/jvm.adoc[JVM] | ||
| ** xref:reference/kafka.adoc[Kafka] | ||
| ** xref:reference/mail.adoc[Jakarta Mail] |
Member
There was a problem hiding this comment.
Items should be sorted alphabetically at the same level. I'll update this.
| message.setText("Mail from Micrometer instrumentation"); | ||
|
|
||
| // this operation will create a "mail.send" observation | ||
| transport.sendMessage(message, message.getAllRecipients()); |
Member
There was a problem hiding this comment.
I understand we wouldn't be able to run this code in a test, but I wonder if it may still be worth making it into a snippet so that it at least gets checked by the compiler. We can consider that as a follow-up to this PR.
Signed-off-by: ddingjoo <ddingsha9@teambind.co.kr>
99f8585 to
442f921
Compare
Contributor
Author
|
Thanks for the review! Appreciate it. |
etrandafir93
pushed a commit
to etrandafir93/micrometer
that referenced
this pull request
Mar 21, 2026
* add a new reference page for Jakarta Mail instrumentation * register the page in docs navigation * add Jakarta Mail to the Observation instrumented projects table Closes micrometer-metricsgh-6485 Signed-off-by: ddingjoo <ddingsha9@teambind.co.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Closes #6485