Skip to content

List more bindable actions in help keybindings#3685

Merged
JoeKar merged 1 commit intomicro-editor:masterfrom
Andriamanitra:list-more-keybindings2
Mar 11, 2025
Merged

List more bindable actions in help keybindings#3685
JoeKar merged 1 commit intomicro-editor:masterfrom
Andriamanitra:list-more-keybindings2

Conversation

@Andriamanitra
Copy link
Contributor

continued from #3124 (I found it easier to make a new pull request than try to resolve conflicts)

@JoeKar wrote:

But it still doesn't really fit to the content of bufpane.go#L686 or am I overlooking something (108 vs 112 entries)? Additionally it would be easier to maintain when we stick to the same order in both lists, then it can simply being diffed.

The actions should now match the code (including the order).

Copy link
Member

@JoeKar JoeKar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is easy to diff. 👍

What do you think, shall we sort them in alphabetical order (doc & code)?

@Andriamanitra
Copy link
Contributor Author

What do you think, shall we sort them in alphabetical order (doc & code)?

While that would make the list easier to skim (especially in the docs) I'm leaning towards no because that would separate closely related actions like VSplit/HSplit, StartOfLine/EndOfLine, PreviousTab/NextTab, etc.

@JoeKar
Copy link
Member

JoeKar commented Mar 11, 2025

Ok, good point. Then we leave it as is.

@JoeKar JoeKar merged commit 7d16dcd into micro-editor:master Mar 11, 2025
6 checks passed
theredcmdcraft pushed a commit to theredcmdcraft/micro that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants