Skip to content

UPV Visualization for Arm/Leg Guides in Component Guide Mode#567

Merged
miquelcampos merged 11 commits intomgear-dev:masterfrom
ordinc:upv_visualizer
Oct 12, 2025
Merged

UPV Visualization for Arm/Leg Guides in Component Guide Mode#567
miquelcampos merged 11 commits intomgear-dev:masterfrom
ordinc:upv_visualizer

Conversation

@ordinc
Copy link
Copy Markdown
Contributor

@ordinc ordinc commented Oct 11, 2025

Description of Changes

Constructed the UPV Visualization Module of the arm and leg guide stages, and applied this function to the arm and leg components.

Testing Done

upv_vis

upv_vis01

Related Issue(s)

http://forum.mgear-framework.com/t/upv-visualization-for-arm-leg-guides-in-component-guide-mode/4981/6

ordinc added 11 commits October 11, 2025 20:52
Add UPV Visualization Module files
Applying the UPV Visualization Module in arm_2jnt_01
Applying the UPV Vis Module in arm_2jnt_02
Uniform scaling factor set to 0.5
Applying the UPV Vis Module in arm_2jnt_03
Using a uniform scaling factor of 0.5
Applying the UPV Vis Module in arm_2jnt_04
Using a uniform scaling factor of 0.5
Applying the UPV Vis Module in arm_2jnt_freeTangents_01
Applying the UPV Vis Module in leg_2jnt_01
Applying the UPV Vis Module in leg_2jnt_02
Applying the UPV Vis Module in leg_2jnt_freeTangents_01
Applying the UPV Vis Module in leg_3jnt_01
@ordinc
Copy link
Copy Markdown
Contributor Author

ordinc commented Oct 11, 2025

I'm sorry, I've put the link to the relevant community post in the wrong place. Also, the link itself seems to be problematic, and I can't fix it myself. Could you please help me correct it?

@miquelcampos
Copy link
Copy Markdown
Member

@ordinc Thanks I will check it very soon.
Btw: did you closed on purpose your other PR? 😅

No worries about the link 😄

@miquelcampos miquelcampos self-assigned this Oct 11, 2025
@miquelcampos miquelcampos added the enhancement New feature or request label Oct 11, 2025
@github-project-automation github-project-automation bot moved this to To Do in mGear DEV Oct 11, 2025
@miquelcampos miquelcampos moved this from To Do to WIP in mGear DEV Oct 11, 2025
@ordinc
Copy link
Copy Markdown
Contributor Author

ordinc commented Oct 11, 2025

@miquelcampos I’m really sorry, I accidentally closed the previous PR about quickly updating component types by mistake—I’m still new to Git😅

@miquelcampos miquelcampos merged commit d107c31 into mgear-dev:master Oct 12, 2025
0 of 3 checks passed
@github-project-automation github-project-automation bot moved this from WIP to 5.2.0 in mGear DEV Oct 12, 2025
@ordinc
Copy link
Copy Markdown
Contributor Author

ordinc commented Oct 13, 2025

@miquelcampos While testing the 'EPIC Template Samples', I discovered a bug in upv_visualizer.py. Instead of directly connecting the scale attribute, it should use the scale decomposed from the world matrix. This way, when the component's parent has scaling applied, the correct scale value can be obtained.

My adjustment is shown in the image below:

compare

My question is: if I fix this bug and update the EPIC_arm and EPIC_leg components, do I need to submit a new PR?

@miquelcampos
Copy link
Copy Markdown
Member

@ordinc Thanks for the info!
I can add the change following the changes in the image
Thanks!

@miquelcampos miquelcampos moved this from 5.2.0 to WIP in mGear DEV Oct 14, 2025
miquelcampos added a commit that referenced this pull request Oct 14, 2025
MISC updates WIP.  Planning to change the logic under a new method self.add_upv_vis #567
@miquelcampos
Copy link
Copy Markdown
Member

@ordinc
I did the update, but also planning to move some logic from the component to a centralized method on the component object
I will add more changes soon
;)

@ordinc
Copy link
Copy Markdown
Contributor Author

ordinc commented Oct 14, 2025

Sounds good. Looking forward to the upcoming changes.
During the process of updating the guide, there are duplicate naming structures in the scene (root, elbow/knee, wrist/ankle, eff, upv). This results in overly long names when creating nodes for calculating UPV positions. Therefore, in upv_visualizer.py, all parameters involving node names should use shortName. For specific details, please refer to the image below.

shortName

@miquelcampos miquelcampos moved this from WIP to 5.2.0 in mGear DEV Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: 5.2.0

Development

Successfully merging this pull request may close these issues.

2 participants