Skip to content

Corrección de JInternalFrame, Correcto.#119

Closed
ronaldoats wants to merge 5 commits into
mgarin:masterfrom
ronaldoats:master
Closed

Corrección de JInternalFrame, Correcto.#119
ronaldoats wants to merge 5 commits into
mgarin:masterfrom
ronaldoats:master

Conversation

@ronaldoats

Copy link
Copy Markdown

Corregí el JInternalFrame, ya que el original tiene problemas con la barra
"createNorthPane"
Ya que se quedaba pegada, Saludos.

@ronaldoats

Copy link
Copy Markdown
Author

Este código tira error en la corrección que te envié.
"FocusManager.unregisterFocusTracker ( WebInternalFrameUI.this );"
Solo comentarlo y listo.

@mgarin

mgarin commented May 11, 2014

Copy link
Copy Markdown
Owner

Wow, that is a really big bunch of changes there...

But I will be rolling a lot of changes for WebInternalFrame with v1.28 update which are kinda unmergable with your changes. Plus you changes seems to remove demo part of code from the sources at all which is kinda really bad...

Could you say what was actually fixed except FocusTracker removal from WebInternalFrameUI and WebSpinnerStyle reference issue? I will include those fixes manually in the next update as I can't actually merge this pull request.

@mgarin mgarin self-assigned this May 11, 2014
@mgarin mgarin added this to the Small issues milestone May 11, 2014
mgarin added a commit that referenced this pull request May 11, 2014
@ronaldoats

Copy link
Copy Markdown
Author

i'm sorry,is that I'm new to GitHub, and the examples, but only delete them personally, to compile my own weblaf.jar, and that are not included.
Sorry.
Translated with google

@mgarin

mgarin commented May 12, 2014

Copy link
Copy Markdown
Owner

There is actually no need to delete them (even locally) - there is a prepared ANT build script that can build all versions of WebLaF binaries (including the one that doesn't include demo).

I have invluded WebSpinnerStyle reference issue. Does your commit include any other changes? - except internal frame changes, I will be adding my own fixes for it later so metal implementation is out of question.

@mgarin

mgarin commented Jun 26, 2014

Copy link
Copy Markdown
Owner

I will close this pull request since I am actually unable the merge this.

Updates for WebInternalFrame are unfortunately delayed to v1.29 due to tons of changes I already have in current version, but v1.29 will come faster than v1.28 and will include the fixes for sure.

@mgarin mgarin closed this Jun 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants