Expose logs when container started but exited with errors#527
Merged
Conversation
* disable container auto-remove, only remove it when it fails to start * call /containers/id/logs endpoint to get the logs
metrue
commented
May 16, 2020
| } | ||
|
|
||
| if err := api.RemoveContainer(createRes.ID); err != nil { | ||
| return errors.Wrap(err, "remove container failed") |
Owner
Author
There was a problem hiding this comment.
Should append the logs into error message
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
==========================================
- Coverage 25.45% 24.71% -0.74%
==========================================
Files 54 53 -1
Lines 1878 1922 +44
==========================================
- Hits 478 475 -3
- Misses 1320 1367 +47
Partials 80 80
Continue to review full report at Codecov.
|
metrue
added a commit
that referenced
this pull request
May 16, 2020
Expose logs when container started but exited with errors (#527)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Close #502
Summary:
The checklist before PR is ready for review: