Merged
Conversation
* add --host and --kubeconf to `fx up` * remove `fx infra list` and `fx infra use` * put assets into skip dir for golangci * fix lint issue * upgrade go-ssh-client to consume the 'Connectable' API, enable more friendly SSH connection error message * parse 'host' and 'kubeconf' for `fx list` and `fx down` also * refactor parse * clean infra stuff
Codecov Report
@@ Coverage Diff @@
## production #492 +/- ##
==============================================
- Coverage 25.91% 24.42% -1.49%
==============================================
Files 63 55 -8
Lines 2335 1863 -472
==============================================
- Hits 605 455 -150
+ Misses 1615 1333 -282
+ Partials 115 75 -40
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Summary:
The checklist before PR is ready for review: