Skip to content

Simplify fx infra#485

Merged
metrue merged 19 commits intomasterfrom
simplify-fx-infra
Mar 18, 2020
Merged

Simplify fx infra#485
metrue merged 19 commits intomasterfrom
simplify-fx-infra

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Mar 16, 2020

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #485 into master will decrease coverage by 3.71%.
The diff coverage is 27.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   25.91%   22.19%   -3.72%     
==========================================
  Files          63       56       -7     
  Lines        2335     1874     -461     
==========================================
- Hits          605      416     -189     
+ Misses       1615     1385     -230     
+ Partials      115       73      -42
Impacted Files Coverage Δ
context/context.go 71.42% <ø> (ø) ⬆️
container_runtimes/docker/http/api.go 0% <0%> (ø) ⬆️
infra/k8s/init_container.go 0% <0%> (ø) ⬆️
middlewares/build.go 0% <0%> (ø) ⬆️
infra/k8s/deployment.go 0% <0%> (ø) ⬆️
middlewares/provision.go 0% <0%> (ø) ⬆️
handlers/list.go 0% <0%> (ø) ⬆️
middlewares/driver.go 0% <0%> (ø)
middlewares/parse.go 31.18% <44.73%> (+3.49%) ⬆️
handlers/up.go 54.83% <52.38%> (-6.7%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df1c64...e9f9de4. Read the comment docs.

@metrue metrue merged commit e712e3d into master Mar 18, 2020
@metrue metrue deleted the simplify-fx-infra branch March 18, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant