Skip to content

Remove infra#487

Merged
metrue merged 9 commits intosimplify-fx-infrafrom
remove-infra
Mar 17, 2020
Merged

Remove infra#487
metrue merged 9 commits intosimplify-fx-infrafrom
remove-infra

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Mar 17, 2020

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

@metrue metrue changed the base branch from master to simplify-fx-infra March 17, 2020 13:02
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #487 into simplify-fx-infra will decrease coverage by 2.6%.
The diff coverage is 22.85%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           simplify-fx-infra     #487      +/-   ##
=====================================================
- Coverage              24.95%   22.35%   -2.61%     
=====================================================
  Files                     58       55       -3     
  Lines                   2164     1861     -303     
=====================================================
- Hits                     540      416     -124     
+ Misses                  1530     1372     -158     
+ Partials                  94       73      -21
Impacted Files Coverage Δ
middlewares/provision.go 0% <0%> (ø) ⬆️
handlers/list.go 0% <0%> (ø) ⬆️
middlewares/parse.go 31.18% <0%> (-2.91%) ⬇️
middlewares/build.go 0% <0%> (ø) ⬆️
handlers/up.go 54.83% <52.38%> (-6.7%) ⬇️
infra/docker/cloud.go 45.9% <71.42%> (+5.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd95d5...a5bad65. Read the comment docs.

@metrue metrue merged commit e9f9de4 into simplify-fx-infra Mar 17, 2020
@metrue metrue deleted the remove-infra branch March 17, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant