Skip to content

fix wrong cloud type issue#419

Merged
metrue merged 1 commit intomasterfrom
fix-wrong-cloud-type
Dec 18, 2019
Merged

fix wrong cloud type issue#419
metrue merged 1 commit intomasterfrom
fix-wrong-cloud-type

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Dec 18, 2019

Signed-off-by: Minghe Huang h.minghe@gmail.com

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

Signed-off-by: Minghe Huang <h.minghe@gmail.com>
@metrue metrue merged commit 0a6784e into master Dec 18, 2019
@metrue metrue deleted the fix-wrong-cloud-type branch December 18, 2019 12:22
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #419 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   34.01%   34.01%           
=======================================
  Files          48       48           
  Lines        2193     2193           
=======================================
  Hits          746      746           
  Misses       1327     1327           
  Partials      120      120
Impacted Files Coverage Δ
middlewares/provision.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fd3c7...9186cd2. Read the comment docs.

metrue added a commit that referenced this pull request Dec 19, 2019
* add contributor badge (#418)

* fix wrong cloud type issue (#419)

Signed-off-by: Minghe Huang <h.minghe@gmail.com>

* simple and clean code (#420)

Signed-off-by: Minghe Huang <h.minghe@gmail.com>

* Squashed commit of the following:

commit f4e3d78e516f889a0256c6ddf922922ec12bc757
Author: Minghe Huang <h.minghe@gmail.com>
Date:   Wed Dec 18 21:02:43 2019 +0800

    check error when walk directory

    Signed-off-by: Minghe Huang <h.minghe@gmail.com>

* add perl support,

fx up func.pl

Signed-off-by: Minghe Huang <h.minghe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant