Conversation
|
Cool, will test this in my staging env; from time to time I also have a similar issue (might be related) where especially when the app is suspended in iOS and then brought back up, the current Meteor.user() is undefined. |
|
Can you please open an issue on the Meteor.user problem including a minimal repro code? I have some null user errors on my server and it might be related |
Will try to, however this seems really hard to reproduce. Sometimes got |
bratelefant
left a comment
There was a problem hiding this comment.
Looks fine, works fine. For testing this (I'm using the "local collections" companion package) I needed to bump peerDependencies for that package; can you the version numbers of core to the peerDeps of the companion packages as well?
do not save token Id, if value is null
|
Sorry reviews got dismissed after merge. I disabled that option for now. Can you please approve again? |
bratelefant
left a comment
There was a problem hiding this comment.
Look good, think we could merge in #150 as well
Summary
In rare occasions I found that when using
NetInfo: nullin order to manually manage connect/disconnect, I can't get the App connected, due to the events being fired before the listeners were attached internally.I therefore moved the code to call Data.dpp.connect at a point after the listeners were set up.
Should not break current builds.
Linked issue(s)
Involved parts of the project
Added tests?
Targeted Meteor release version
Reproduction
install
@meteorrn/core@2.8.1-rc.0to test